opentok / opentok-android-sdk-samples

Sample applications illustrating best practices using OpenTok Android SDK.
https://tokbox.com/developer/sdks/android/
MIT License
211 stars 169 forks source link

Proguard config for signed app? #178

Closed jaytarub closed 5 years ago

jaytarub commented 5 years ago
marinaserranomontes commented 5 years ago

Hi @jaytarub ,

As you observe, we have not included proguard in the samples. Having Proguard run is completely optional, but highly recommended. You can find more details in the Android doc: http://developer.android.com/guide/developing/tools/proguard.html

Best, Marina

marinaserranomontes commented 5 years ago

Hi @jaytarub ,

I’m closing this issue because it has been inactive for a few weeks.

Please reopen if you still encounter this issue. You can also contribute directly to samples by providing a patch.

Thank you!

Best, Marina

zhuosun-rally commented 5 years ago

could you guide us how to config the opentok proguard? like what's the special class need be keep in proguard.

RKSharma89 commented 5 years ago

Here are the proguard rules for OpenTok: -keep class com.opentok.{ ; } -keepclassmembers class com.opentok.{ ; } -dontwarn com.opentok.* -keep class org.webrtc. { ; }

MinkiPani commented 4 years ago

Here are the proguard rules for OpenTok: -keep class com.opentok.{ ; } -keepclassmembers class com.opentok.{ ; } -dontwarn com.opentok.* -keep class org.webrtc. { ; }

hello, these rules are way too broad, is basically says "don't touch any of the classes from my SDK" could you please define the rules more fine grained for us?

cdreyfus commented 4 years ago

There's a mistake in the above rules: -keep class org.webrtc.* { ; } -dontwarn com.opentok. -keep class com.opentok. { ; } -keepclassmembers class com.opentok.{ ; }

palmas commented 4 years ago

This seems to be ok:

-keep class com.opentok.* { ; } -keep class org.webrtc.* { ; }

dp85 commented 2 years ago

In 2.22.1 I also needed:

-keep class com.vonage.* { ; }

mzekrallah commented 2 years ago

With new vonage sdks, only this configuration will work:

-keep class com.opentok. { *; } -keep class com.vonage.* { ; } -keep class org.webrtc. { *; } -keep class org.otwebrtc.* { ; }

DmytroBatyuk commented 1 month ago

These works for me

-keep class com.opentok.** { *; }
-keep class com.vonage.** { *; }
-keep class org.webrtc.** { *; }
-keep class org.otwebrtc.** { *; }