opentok / opentok-android-sdk-samples

Sample applications illustrating best practices using OpenTok Android SDK.
https://tokbox.com/developer/sdks/android/
MIT License
211 stars 169 forks source link

OPENTOK-43278: Replace Android samples bintray links with Maven Central links #378

Closed jintgeorge closed 3 years ago

jintgeorge commented 3 years ago

Replace Android samples bintray links with Maven Central links.

igorwojda commented 3 years ago

It looks like JCenter is part of Bintray, so we should remove jCenter() repos:

To streamline the productivity of the JFrog Platform we will be sunsetting Bintray (including JCenter), GoCenter, and ChartCenter services on May 1st, 2021.

v-kpheng commented 3 years ago

It looks like JCenter is part of Bintray, so we should remove jCenter() repos:

To streamline the productivity of the JFrog Platform we will be sunsetting Bintray (including JCenter), GoCenter, and ChartCenter services on May 1st, 2021.

Thanks, @igorwojda. Good catch!

@jintgeorge, can you please update and test again please? Thanks!

jintgeorge commented 3 years ago

@igorwojda Can you please review again?

v-kpheng commented 3 years ago

@jintgeorge, can we still remove jcenter? I thought the plan was to leave it in place?

(Because without it, our sample apps won't compile because of the missing dependences)

Please advise. Thanks!

v-kpheng commented 3 years ago

@jintgeorge, can we still remove jcenter? I thought the plan was to leave it in place?

(Because without it, our sample apps won't compile because of the missing dependences)

Please advise. Thanks!

@jintgeorge, please advise. ☝️ Thanks!

jintgeorge commented 3 years ago

@v-kpheng We are not removing jcenter completely from our sample apps. The ones removed are only for opentok-android-sdk which have been already migrated to Maven Central.

jintgeorge commented 3 years ago

@igorwojda Can you review this again please?

igorwojda commented 3 years ago

Looks good - I am merging this now.

BTW @v-kpheng samples are guarded by various CI checks running with each PR (via Github actions) - each app is built and over 200 Unit tests run to verify various consistency aspects across all samples.

jintgeorge commented 3 years ago

Thanks @igorwojda