opentok / opentok-android-sdk-samples

Sample applications illustrating best practices using OpenTok Android SDK.
https://tokbox.com/developer/sdks/android/
MIT License
211 stars 169 forks source link

Expose method for changing video background color #411

Closed victorkifer closed 1 year ago

victorkifer commented 2 years ago

When you set video style to fit (setStyle(BaseVideoRenderer.STYLE_VIDEO_SCALE, BaseVideoRenderer.STYLE_VIDEO_FIT)) on PublisherKit or SubscriberKit, the video will be fit into the view and so it's possible to have black borders on some sides.

I would like to be able to change that color. IMO it makes sense to expose it via PublisherKit/SubscriberKit or BaseVideoRenderer. It seems like just storing it in renderer and using it in GLES20.glClearColor(); method should do the trick.

v-kpheng commented 1 year ago

Thanks, @victorkifer, for this suggestion.

There's no plans for this API but that may change in the future.

CC'ing @Daniel085, since this is product request.