opentok / opentok-android-sdk-samples

Sample applications illustrating best practices using OpenTok Android SDK.
https://tokbox.com/developer/sdks/android/
MIT License
210 stars 169 forks source link

Opentok 47720 - Update samples for Android SKD regarding the use of Custom Audio Driver and READ_PHONE_STATE permission #425

Closed goncalocostamendes closed 2 years ago

goncalocostamendes commented 2 years ago

What is this PR doing?

READ_PHONE_STATE permission is needed, on versions built targeting API level 31 can react appropriately to incoming and outgoing calls. In case the permissions are not granted, to prevent a crash, validations of current version were added.

How should this be manually tested?

Configure following versions:

Run samples mentioned below on Android Studio:

For each one, verify if when connecting and publishing using Playground, the app does not crash.

What are the relevant tickets? OPENTOK-47720

vona-ben commented 2 years ago

Hi @goncalocostamendes @jintgeorge Since it's approved, possible to merge this?

Thanks.

goncalocostamendes commented 2 years ago

@vona-ben yes, I do it

goncalocostamendes commented 2 years ago

@vona-ben did you also test this PR?