search

opentok / opentok-android-sdk-samples

Sample applications illustrating best practices using OpenTok Android SDK.
https://tokbox.com/developer/sdks/android/
MIT License
210 stars 169 forks source link

VIDCS-869: Fix crash when toggling video #462

Closed vona-ben closed 1 year ago

vona-ben commented 1 year ago

What is this PR doing?

Fixes an issue where crashing may occur when toggling video

How should this be manually tested?

To reproduce, follow the steps detailed in https://github.com/opentok/opentok-android-sdk-samples/issues/461

To confirm fix, checkout this branch and then follow the same steps as before 🎉

juliobecerragomez commented 1 year ago

Has this been updated based on our default camera2 capturer?

vona-ben commented 1 year ago

@juliobecerragomez @goncalocostamendes Those changes have been taken from the native SDK code. I haven't made any modifications other than renaming variables and fixing the logs. I think @jintgeorge would be best to reply to the comment here (cc @v-kpheng )

goncalocostamendes commented 1 year ago

@juliobecerragomez @goncalocostamendes Those changes have been taken from the native SDK code. I haven't made any modifications other than renaming variables and fixing the logs. I think @jintgeorge would be best to reply to the comment here (cc @v-kpheng )

Yes, just confirmed it is the same as native SDK. Approving

juliobecerragomez commented 1 year ago

@vona-ben So at least we should fix the commented out code. I do not think it is ok to show it as part of the linux sample apps.

vona-ben commented 1 year ago

@vona-ben So at least we should fix the commented out code. I do not think it is ok to show it as part of the linux sample apps.

Done