opentok / opentok-macos-sdk-samples

MIT License
2 stars 1 forks source link

Custom Video Capturer example does not run as is. #16

Closed MichaelCG8 closed 1 year ago

MichaelCG8 commented 1 year ago

Describe the bug Unlike all the other examples in this repo, I can't run the custom video capturer as is. It crashes with EXC_BAD_ACCESS on line 59 of OTVideoCaptureProxy.m. The line of code is OTMacDefaultVideoCapturer* proxy = (__bridge OTMacDefaultVideoCapturer *)(capturer_cb->user_data);

To Reproduce Clone the repo, install the sdk using SPM, set the signing team to your team. Build and run.

Expected behavior No crash, I presume it's meant to behave much like the Basic capture example, but with modifiable behaviour.

Screenshots N/A

Device (please compete the following information):

Additional context

rktalusani commented 1 year ago

created a PR with fix PR #17

v-kpheng commented 1 year ago

@MichaelCG8, the issue should be fixed, given https://github.com/opentok/opentok-macos-sdk-samples/pull/17 was merged in.

Any issues, please let us know. Thanks!