search

opentok / opentok-macos-sdk-samples

MIT License
2 stars 2 forks source link

Added custom video capture sample #7

Closed rktalusani closed 1 year ago

rktalusani commented 1 year ago

AVCaptureDeviceDiscoverySession warning is there in Mac SDK too so i didn't touch it.

jvalli commented 1 year ago

AVCaptureDeviceDiscoverySession warning is there in Mac SDK too so i didn't touch it.

Ok, this is something that we will need to investigate. Did you notice any problems at runtime?

rktalusani commented 1 year ago

no runtime issues

IGitGotIt commented 1 year ago

When I close the app, the audio still goes on

IGitGotIt commented 1 year ago

Typically I like to add a subscribe to self flag in the code , so I don't have to go outside the app to start a session, publish etc 

void publisher_on_stream_created(otc_publisher *publisher, void *user_data, const otc_stream *stream) {
     session_on_stream_received(session, user_data, stream);
}

You decide if you want it.. not an issue for me..

rktalusani commented 1 year ago

are we ok to merge now? any blocking issues?

jvalli commented 1 year ago

are we ok to merge now? any blocking issues?

I am still seeing pods configuration on the xcodeproj, did you run pod deintegrate?

IGitGotIt commented 1 year ago

are we ok to merge now? any blocking issues?

Raj, did https://github.com/opentok/opentok-macos-sdk-samples/pull/7#issuecomment-1442599367 get fixed? Thanks

rktalusani commented 1 year ago

When I close the app, the audio still goes on fixed by implementing window close handler.

Also ran pod deintegrate

v-kpheng commented 1 year ago

Merging, since @jvalli tested already and @chetanvangadiTokbox gave us a 👍.