opentok / opentok-network-test

Sample app to test network connectivity and statistics (bps, packet-lost)
MIT License
112 stars 56 forks source link

iOS Readme : checkQualityAndDisconnectSession confusion #13

Closed guiracine closed 8 years ago

guiracine commented 8 years ago

I was a bit confused when reading the [OTNetworkTest checkQualityAndDisconnectSession] explanation where the end result are displayed :

BOOL canDoVideo = (video_bw < 50000 || video_pl_ratio > 0.03);
BOOL canDoAudio = (audio_bw < 25000 || audio_pl_ratio > 0.05);

canDoVideo looks a cannotDoVideo to me, it should be more something like

BOOL canDoVideo = (video_bw >= 50000 && video_pl_ratio <= 0.03);
BOOL canDoAudio = (audio_bw >= 25000 && audio_pl_ratio <= 0.05);

I would be even more explicit like :

BOOL canDoExcellent640x480 = (video_bw >= 600000 && video_pl_ratio <= 0.05);