Closed guiracine closed 8 years ago
I was a bit confused when reading the [OTNetworkTest checkQualityAndDisconnectSession] explanation where the end result are displayed :
[OTNetworkTest checkQualityAndDisconnectSession]
BOOL canDoVideo = (video_bw < 50000 || video_pl_ratio > 0.03); BOOL canDoAudio = (audio_bw < 25000 || audio_pl_ratio > 0.05);
canDoVideo looks a cannotDoVideo to me, it should be more something like
canDoVideo
cannotDoVideo
BOOL canDoVideo = (video_bw >= 50000 && video_pl_ratio <= 0.03); BOOL canDoAudio = (audio_bw >= 25000 && audio_pl_ratio <= 0.05);
I would be even more explicit like :
BOOL canDoExcellent640x480 = (video_bw >= 600000 && video_pl_ratio <= 0.05);
I was a bit confused when reading the
[OTNetworkTest checkQualityAndDisconnectSession]
explanation where the end result are displayed :canDoVideo
looks acannotDoVideo
to me, it should be more something likeI would be even more explicit like :