Update README benchmarks 3% packetloss Acceptable

opentok / opentok-network-test

Sample app to test network connectivity and statistics (bps, packet-lost)

MIT License

112 stars 56 forks source link

Closed dylanjha closed 7 years ago

dylanjha commented 7 years ago

It appears like this is a typo in the README. It wouldn't make sense for packetloss percentage for 'Excellent' to be higher than 'Acceptable'
It looks like the 'Acceptable' threshold for packetloss should be 3% and the 'Excellent' threshold should be 0.5%
The code also checks for 3% for video (packetLossRatioPerSecond: 0.03):
https://github.com/opentok/opentok-network-test/blob/a9ea9331d99aea890af74877aad80a0e952cc6b7/js-sample/app.js#L26

wobbals commented 7 years ago

LGTM, good catch. Thanks Dylan!