opentok / opentok-nexmo-sip

OpenTok SIP Interconnect samples with Nexmo Voice API
MIT License
5 stars 16 forks source link

Updating dial-out to use Long virtual number as FROM #3

Closed javiermolsanz closed 3 years ago

anandpaithankar1 commented 4 years ago

Side note - This application already works with Nexmo as a SIP provider without providing any valid from number. Nexmo also uses SIP based authentication using supplied Nexmo API key and value as SIP username and password. I understand this PR is in relation with the article, but it is not mandatory to have LVN. Our customers also refer this application very often, so I don't want to using LVN as a mandatory step adding to confusion.

javiermolsanz commented 4 years ago

I'd rewrite this paragraph as follows -

  • Sign up for a Nexmo account to get the API Key and Secret.

Optionally, you can also rent a Long Virtual Number (LVN) from Nexmo or your preferred provider to use it for Call Line Identifier (CLI). This LVN can be set in from field to be used as a CLI. Although, this step is not mandatory, however, the downstream carriers may reject the call if the correct CLI has not been specified as explained in this article

Sounds good to me :)

anandpaithankar1 commented 4 years ago

Thank you for improving.