search

opentok / opentok-react-native

OpenTok React Native - a library for OpenTok iOS and Android SDKs
https://tokbox.com/
MIT License
210 stars 155 forks source link

Please bump the opentok Android to 2.24.0 #629

Closed nicwise closed 1 year ago

nicwise commented 1 year ago

We've been hitting this a lot

https://tokbox.com/developer/sdks/android/release-notes.html

This version fixes an issue in which participants could not hear audio published by clients using certain models of Huawei devices.

We are going to patch node_modules for the moment, but it'd be lovely to get this into a proper release.

enricop89 commented 1 year ago

I need to fix https://github.com/opentok/opentok-react-native/issues/628 before updating

pietgk commented 1 year ago

As opentok-android-sdk:2.24.1 fixes a bluetooth headset reconnect issue, i would like to see the update to 2.24.1. I patched it in my local BasicVideoChat test:

and OTSessionManager.java with a temp fix of commenting out the @Override 

// @Override
public boolean isCamera2Capable() {

Then tested it for the headset reconnect issue and that worked.

nicwise commented 1 year ago

@enricop89 any news on #628 ? this one is causing us a lot of issues with hauwei phones :(

pietgk commented 1 year ago

@enricop89 i got the request (from Roger F) to test 0.21.2 but i would really appreciate that i could test the version with the upgrade of android to at least 2.24.0. Any feedback on when that might be?

enricop89 commented 1 year ago

Hi @pietgk , if urgent you can edit the Android version here.

FYI: @jeffswartz

Panda-ref commented 1 year ago

Also, current opentok-android-sdk:2.23.1 depends on WebRTC » 84.0.21 (1361.7 MB) which dramatically increases the resulting app size like x2 compared to previous version.