search

opentok / opentok-react-native

OpenTok React Native - a library for OpenTok iOS and Android SDKs
https://tokbox.com/
MIT License
210 stars 155 forks source link

Release 2.25.4 has a coding error in OTSubscriber.js #694

Closed GaryGiebler closed 9 months ago

GaryGiebler commented 10 months ago

Line 44 of OTSubscriber.js reads:

    const { subscribeToAudio, subscribeToVideo, subscribeToCaptions, preferredResolution, preferredFrameRate } = individualStreamProperties;

but needs to be:

    const { subscribeToAudio, subscribeToVideo, subscribeToCaptions, preferredResolution, preferredFrameRate, audioVolume } = individualStreamProperties;

Otherwise, app crashes with an exception on line 60 where audioVolume can't be found.

GaryGiebler commented 10 months ago

Additionally, this release doesn't fix the session disconnect freeze issue on our server using mobile devices.

jeffswartz commented 10 months ago

Thanks for reporting @GaryGiebler. We're working these issues.

marinaserranomontes commented 9 months ago

Hi @GaryGiebler

The OTSubscriber issue should be resolved in the latest version published V2.26.1, please, could you retry?

Thanks.

GaryGiebler commented 9 months ago

We will try version 2.26.1 this week. Thank you.

Gary Giebler Senior Principal Software Engineer Tel: +1 610-933-0332 Mobile: +1 610-608-7052 @.*** www.ICONplc.com

[signature_1079392530]

[signature_3352172825]

From: marina serrano montes @.> Date: Monday, November 6, 2023 at 11:25 AM To: opentok/opentok-react-native @.> Cc: Giebler, Gary @.>, Mention @.> Subject: [EXTERNAL] Re: [opentok/opentok-react-native] Release 2.25.4 has a coding error in OTSubscriber.js (Issue #694)

Hi @GaryGieblerhttps://github.com/GaryGiebler

The OTSubscriber issue should be resolved in the latest version published V2.26.1, please, could you retry?

Thanks.

— Reply to this email directly, view it on GitHubhttps://github.com/opentok/opentok-react-native/issues/694#issuecomment-1795345193, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ6AJD42H2KEKHHKWA3OJKTYDEFN5AVCNFSM6AAAAAA55Z3XE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVGM2DKMJZGM. You are receiving this because you were mentioned.Message ID: @.***>

ICON plc made the following annotations.

This e-mail transmission may contain confidential or legally privileged information that is intended only for the individual or entity named in the e-mail address. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or reliance upon the contents of this e-mail is strictly prohibited. If you have received this e-mail transmission in error, please reply to the sender, so that ICON plc can arrange for proper delivery, and then please delete the message.

Thank You,

ICON plc South County Business Park Leopardstown Dublin 18 Ireland Registered number: 145835