opentok / opentok-react-native

OpenTok React Native - a library for OpenTok iOS and Android SDKs
https://tokbox.com/
MIT License
210 stars 155 forks source link

fix(android): Set minSdkVersion to 23 #700

Closed simonboisset closed 3 months ago

simonboisset commented 10 months ago

Hi

I've submitted this Pull Request to update your library to be compatible with the latest Expo version. The change involves setting minSDKVersion to 23.

Updating to minSDKVersion 23 ensures compatibility with the latest Expo features, enhancing the user experience for Expo developers using your library.

NobodyButMe-Haiya commented 9 months ago

up .. we need this patch also

simonboisset commented 9 months ago

If it can help

This fix with expo plugin is working for me:

const withOpentokPlugin: ConfigPlugin = (config) => {
  const manifestConfig = withAndroidManifest(config, (newConfig) => {
    newConfig.modResults.manifest['uses-sdk'] = [
      ...(newConfig.modResults.manifest['uses-sdk'] || []),
      { $: { 'tools:overrideLibrary': 'com.opentok.android, com.vonage.mltransformers' } },
    ];

    return newConfig;
  });

  return manifestConfig;
};

export default withOpentokPlugin(expoConfig)