search

opentok / opentok-react

React components for OpenTok.js
https://www.npmjs.com/package/opentok-react
MIT License
107 stars 105 forks source link

The switch between camera and screen is too harsh #64

Open nlyn opened 5 years ago

nlyn commented 5 years ago 
    if (shouldUpdate('videoSource', undefined)) {
      this.destroyPublisher();
      this.createPublisher();
      return;
    }

When you switch video source the transition is really harsh. You essentially drop off the call while the new publisher is created and connects to the stream - and in the case of switching to screen sharing, you are off the call for the entire duration of time you select what windows/applications you want to share.

I'd suggest improving this transition so that the existing publisher isn't destroyed until the new publisher is publishing to the stream.

Itzli2000 commented 4 years ago

When I share screen, the audio stops.

How can I keep sharing audio from the same source and share the screen?

alexter42 commented 4 years ago

@nlyn Did you succeed on reducing/skipping the time you are off the call until you select what windows/applications you want to share?

enricop89 commented 3 years ago

This is somehow duplicate of https://github.com/opentok/opentok-react/issues/84. Please check https://github.com/opentok/opentok-react/issues/84#issuecomment-604934795 and https://github.com/nexmo-se/opentok-react-screenshare-sample