search

opentok / opentok-windows-sdk-samples

Sample applications illustrating best practices using OpenTok Windows SDK
MIT License
9 stars 29 forks source link

OPENTOK-48239: Samples with VonageVideoSDK #44

Closed goncalocostamendes closed 1 year ago

goncalocostamendes commented 1 year ago

Sample ready for VonageVideoSDK

v-kpheng commented 1 year ago

@goncalocostamendes, any update? Please advise. Thanks!

goncalocostamendes commented 1 year ago

@v-kpheng there is just a problem we should discuss. By merging this PR we are changing on the csproj files the path to our sdk binaries from packages\OpenTok.Client.2.19.0\lib\net40-client\OpenTokNET.dll to packages\VonageVideoSDK.0.0.1\lib\net40-client\OpenTokNET.dll

which, since we will not make the full migration to VonageVideoSDK now, it not ideal.

When will we fully migrate to VonageVideoSDK? We already tested and it works the release via Vonage name. Should we for now upload the new nuget, but link with the previous one (OpenTok.Client)?

v-kpheng commented 1 year ago

@goncalocostamendes, apologies for the belated reply.

We don't need samples that point to VonageVideoSDK yet. We'll need once we move all our code to Vonage GH org though, but that won't be until sometime in the (not near) future. Can this be closed then?

Please advise. Thanks! 🙏

goncalocostamendes commented 1 year ago

Closing it