Open sergioturgil-vonage opened 1 year ago
@sergioturgil-vonage, why is the filter and watermark important to add to the CustomVideoRenderer sample? An alternative approach would be to create a sample app just to showcase how to add the filter and watermark.
@sergioturgil-vonage, why is the filter and watermark important to add to the CustomVideoRenderer sample? An alternative approach would be to create a sample app just to showcase how to add the filter and watermark.
The PR was already there so I assumed it had been considered important at some point. I didn't want to leave a pull request open indeterminately. I guess the filter and watermark are not really important. I suspect the idea was showcasing how a custom video capturer provides bigger control over the video feed but it's true it also complicates the sample a bit.
We can do what you suggested and add it as a separate sample. Let me know what you think. Thx!
Watermark is a common request and an exemplary example of a Customer Capturer and Renderer. We have customers who want to protect their content hence why the Pr was created a long time back that left there hanging.
The original PR was created by https://github.com/klapperkopp here: https://github.com/opentok/opentok-windows-sdk-samples/pull/34
It looks like it was created as part of a different repo and it was causing some problems so we decided to move it to this new PR.
This sample uses a third party unofficial nuget package not available via nuget.org and therefore it must be included as part of the sample inside the packages folder