search

opentok / opentok-windows-sdk-samples

Sample applications illustrating best practices using OpenTok Windows SDK
MIT License
9 stars 29 forks source link

Vidcs 2381 Upgrade to 2.27.2 with decoupled transformers #70

Closed sergioturgil-vonage closed 2 months ago

sergioturgil-vonage commented 2 months ago

Upgrades to 2.27.2 Adds dependency to new transformers package Adds Noise suppression to new transformers sample Removes unused code.

sergioturgil-vonage commented 2 months ago

NS is being enabled within the VideoTransformers sample. Maybe it was not the best name I could have given the sample on the beginnig. Should we rename it? Or have a different sample for NS

Mmm... You're right. The project's called VideoTransformers so maybe adding NS here is not the best solution. I thought that adding a new sample when there are only 4 new lines was a bit too much.

I think it'd be better to just rename the project name to something like Transformers or MediaProcessing or something like that. I don't think it deserves a separate project. The less projects we have the easier it'll be for people to understand the samples. I can do that in a different PR.

Thx for pointing this out.

goncalocostamendes commented 2 months ago

Perfect. I am doing the same for the other platforms. Transformers, Media Transformers, Media Processing,... All seem good to me. I let you choose ahah