search

opentok / vonage-client-sdk-video

OpenTok iOS SDK Swift Package Manager
Other
0 stars 3 forks source link

Add support to iOS 14+ #16

Open tapz opened 4 months ago

tapz commented 4 months ago

Xcode gives this error when my project has Minimum Deployment target set to 14:

Invalid Bundle. The bundle MyApp.app/Frameworks/OpenTok.framework does not support the minimum OS Version specified in the Info.plist.

OpenTok Package.swift has this:

platforms: [.iOS(.v13)],

johnDaniul commented 4 months ago

We are experiencing this issue as well, and it seems to be related to recent changes in XCode 15.3 and the way SPM packages are handled. This prevents publishing to Apple, as the app gets rejected on upload.

johnDaniul commented 4 months ago

Some further information, as this isn't the only library to have this issue recently. It looks like SPM libraries that distribute binary versions need to make sure to include MinimumOSVersion key in their Info.plist file. This value is now required when building on XCode 15.3 and submitting to Apple. It seems to be generated automatically for SPM libraries that distribute code only, but needs to be manually added into the binary builds.

v-kpheng commented 1 month ago

Apologies for the belated reply. We're investigating this now: https://jira.vonage.com/browse/VIDCS-2459.

~We're~ We are not able to reproduce, though. Using Xcode 15.4 with minimum target 16.4, we were able to upload to TestFlight just fine.

We might be missing something though. Any ideas? Thanks!

n8sters commented 2 weeks ago

As far as I can tell this is specifically on Xcode 15.3, not 15.4. We were having issue updating to 15.4 so we're all kept on 15.3, which is still experiencing the issue. Out min supported version is 16, moving to 17 in a few months. I'm going to investigate moving back to 15.4 since I believe our issues have been resolved, but cannot say for certain yet.

n8sters commented 2 weeks ago

Ok confirmed this is isolated to Xcode 15.3. I tested 15.4 and the issue hitting our team has been resolved so we're updating to use that version, but any dev locked to 15.3 won't be able to use this SDK without some issues if they have a 14.+ min version support.

v-kpheng commented 2 weeks ago

Thanks, @n8sters.

Let me ask Engineering if they can reproduce with 15.3.

n8sters commented 2 weeks ago

Cool cool. I saved the debug log printouts so if you end up needing that just ping me and I can email some snippets over.