opentoken-io / opentoken

Public and free software API to tokenize or encrypt data.
MIT License
13 stars 5 forks source link

Implementing random request IDs #129

Closed fidian closed 7 years ago

fidian commented 7 years ago

This closes #96.

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #129 into master will not change coverage

@@           master   #129   diff @@
====================================
  Files          68     69     +1   
  Lines        1398   1427    +29   
  Methods       160    159     -1   
  Messages        0      0          
  Branches      155    157     +2   
====================================
+ Hits         1398   1427    +29   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 21b3261...e669465

fidian commented 7 years ago

Log time to DOT-517

fidian commented 7 years ago

Updated to address code review concerns. Also added a test to increase the branch-related test coverage.

fidian commented 7 years ago

Fixed everything except the spaces after a function. The style guide says there should be 2 blank lines after functions. Weirdly, that note is under "Comments". https://tests-always-included.github.io/style-guide/general/#comments

fidian commented 7 years ago

Merged!