search

opentomb / OpenTomb

An open-source Tomb Raider 1-5 engine remake
http://opentomb.github.io/
GNU Lesser General Public License v3.0
1.38k stars 143 forks source link

[BIG_UPDATE] Inventory & Weapon #573

Closed ghost closed 5 years ago

ghost commented 5 years ago

Hello @TeslaRus,

It's my update for inventory and weapons, You can check commits and src for detail and if you detect a problem please report it here. PS: sorry for readme :x, this src can be optimized !

Image: medikit_bar tr2_inventory weapon_tr2 screen_20181130_190829 screen_20181130_190647 screen_20181130_190722 screen_20181130_190735

ghost commented 5 years ago

need to pull request the windows project ? because the project have nuget package so no instruction is needed ! i use visual studio 2017 community edition and nuget package instruction is just for linux. PS: OpenAL in extern is added in the windows project. EDIT: i will create a repo for windows project and add it, and add instruction if needed.

Gh0stBlade commented 5 years ago

It won't let me directly respond to your comments but. If the build for windows now uses nuget then that's news to me. I've not looked at the windows build for a long time now.

ghost commented 5 years ago

is working for me so :x you can look it: preview preview_file

PS: openal is already compiled and added in release folder

ghost commented 5 years ago

README_FIXED

ghost commented 5 years ago

FIXED all comment, you can check if i missed something.

TeslaRus commented 5 years ago

Please, use atomic (minimal, single task) PR. One fix, one feature - one PR. It is heavy to review big PR, with multiply features it is heavy twice. Than bigger PR is then more merging conflicts may appear.

ghost commented 5 years ago

It's a [BIG_update] :D sorry :x im change it for other PR i pull here now.

TeslaRus commented 5 years ago

corporate coding standards and opensource practice ;-) all is ok, earn skills in practice )) // I hope it is correct translation to English

ghost commented 5 years ago

thanks :) and yes is correct (but im french so i dont know if is ok :x )

ghost commented 5 years ago

i finish change and i commits the last update. you can preview the src: sound_struct sound

ghost commented 5 years ago

DONT PUSH IT NOW, i have a new update for it and is for inventory, i have added a new page in inventory the "ammo": inventory page: new_inventory ammo page: new_inventory_page can i commit ? it's just to have less item in inventory for select weapon directly, it's just temporarily. or can enable this feature via scripts in future :x

Gh0stBlade commented 5 years ago

Good work

TeslaRus commented 5 years ago

can i commit ? emmm... You can update PR every time You want )

TeslaRus commented 5 years ago

It is ready to merge. Last comment is not necessary. Just say "ready to merge" ;-)

ghost commented 5 years ago

EDIT: missing file sorry :'( EDIT2: you can merge it now :) EDIT3: can you add "strings[051] = "AMMO";" in english generic lua file please ? i missed it :x