[Update] v1.0.2b

[ghost]

hi @TeslaRus, changelog here: Releases ps: need to change cmakelist for weapons.cpp, i'm not using cmake so cmakelists is not included here !

[TeslaRus]

okay... I need some time to review it ;-)

[ghost]

the #c3f200e / #3149b84 and #7604359 are fail, sorry for it :x

[ghost]

thanks you @RICCIARDI-Adrien for reviewing, the last commit, fix all review.

[RICCIARDI-Adrien]

You're welcome @TokyoSU. Here is the patch to add weapons.* files to the CMake build system :

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 518dd8b6..69e4380c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -208,6 +208,8 @@ set(OPENTOMB_SRCS
     src/skeletal_model.c
     src/trigger.cpp
     src/trigger.h
+    src/weapons.cpp
+    src/weapons.h
     src/world.cpp
     src/world.h
 )

[RICCIARDI-Adrien]

There is a sound problem in TR2 : uzis firing sound does not stop playing.

[ghost]

i already know for uzi sound but this bug is also for m16 :x i will fix it

[ghost]

You're welcome @TokyoSU. Here is the patch to add weapons.* files to the CMake build system :

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 518dd8b6..69e4380c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -208,6 +208,8 @@ set(OPENTOMB_SRCS
     src/skeletal_model.c
     src/trigger.cpp
     src/trigger.h
+    src/weapons.cpp
+    src/weapons.h
     src/world.cpp
     src/world.h
 )

i can just push the CMakeLists ? i not familiar with git :x

[TeslaRus]

state control and below will be reviewed later; thanks for PR ;-) P.S. I have to debug changes before merge too - some extra time...

[ghost]

i want to use the "ss_anim->anim_frame_flags == ANIM_FRAME_REVERSE" but it seems that not working for unknown reason. how to use this flag ? i use it with: "ent->character->state.weapon_ready && !ent->character->cmd.action" for more precision. is for uzi and m16 loop fix, but i wan't to fix echo not playing. With (-time) echo sound are working but sound are playing when starting firing. :x

EDIT: -time is good if ANIM_FRAME_REVERSE is used only for echo.

[ghost]

Anim_IncTime can be the problem for the first frame ?

[ghost]

flares can be considered as a weapon ? just need to create a dynamic light and a timer to switch off the light and launch the flare. but for pickup the flare after launched (if light still exists), i dont know how to set up :x

[ghost]

"save/" folder need to be created if not found or the game.cpp throw warning that save can't be created !

[ghost]

@TeslaRus it's ok for merging at any time :) EDIT: not space to tab, it's tab to space :x

[TeslaRus]

Target flag cleaning was lost

[TeslaRus]

resolved manually. work in progress. critical bugs must be fixed.