search

opentomb / OpenTomb

An open-source Tomb Raider 1-5 engine remake
http://opentomb.github.io/
GNU Lesser General Public License v3.0
1.38k stars 143 forks source link

Update Windows Compiler Compatibility #592

Closed ghost closed 5 years ago

ghost commented 5 years ago

the attributes(packed, aligned) not exist on windows compiler (stdc++17), because, if bullet not crash, windows compiler will align the variable correctly. i added some fix like config-opentomb for no cmake user, lua path "AL/". and added new cpp: "timer.cpp" that fix clock_gettime() and gettimeofday (and fix CLOCK_REALTIME too), and fixed "char image_name_buf[]" not compatible with c++17 (maybe need check about it).

Gh0stBlade commented 5 years ago

Pretty sure my solution was more elegant, did TeslaRus not take all of my patches for MSVC?

vvs- commented 5 years ago

For reference it was in #431. What exactly was merged is hard to say, but it looks like it was done on 7-8 April, 2017, so those commits might be worth looking at.

ghost commented 5 years ago

it not exist in the src of opentomb, hmm.. or you not patched the current change i add, i dont know myself :x ?

TeslaRus commented 5 years ago

partially done in 6311fa374504efbb5494b9485990fbb5154da181 new timer - nope... using threads in codec module - stupid idea (my idea)... so timer / threading in codecs will be deleted.

TeslaRus commented 5 years ago

timer will be fixed by other way. thanks for PR