opentomb / OpenTomb

An open-source Tomb Raider 1-5 engine remake
http://opentomb.github.io/
GNU Lesser General Public License v3.0
1.38k stars 143 forks source link

FMV fixes. #595

Closed RICCIARDI-Adrien closed 5 years ago

RICCIARDI-Adrien commented 5 years ago

Following videos were crashing the game when trying to play them (it was due to unsupported audio format) :

Also, FMVs did not started from the beginning.

I'm trying to solve the bug that hangs the game when playing more than one FMV in the row, but you can merge this pull request if it is OK for you.

vvs- commented 5 years ago

Right. They did actually work in the past but become broken at some time before #538.

RICCIARDI-Adrien commented 5 years ago

Pull request is ready for merging.

TeslaRus commented 5 years ago

Thanks for PR. I need some time to check it (I have little time). Can not reproduce video play crash.

RICCIARDI-Adrien commented 5 years ago

You're welcome. I just checked and all videos that were crashing contain localized dialogs. All other videos do not have voice. Maybe my french version is 8-bit encoded but the english-one is 16-bit, like the voiceless videos ?

vvs- commented 5 years ago

I have no crash either in my English version. But I have a lock-up playing any video for the second time. This is the same bug as in #538 where original reporter had non-reproducible crash on one of his computers.