search

opentomb / OpenTomb

An open-source Tomb Raider 1-5 engine remake
http://opentomb.github.io/
GNU Lesser General Public License v3.0
1.39k stars 145 forks source link

Added Linux and Windows CI builds using GitHub Actions #601

Closed RICCIARDI-Adrien closed 4 years ago

RICCIARDI-Adrien commented 4 years ago

Windows build should also be easier even for developing purposes.

TeslaRus commented 4 years ago

try this AL internal, please https://github.com/TeslaRus/OpenTomb/tree/master/extern/al it works on Linux and MinGW too

RICCIARDI-Adrien commented 4 years ago

OK. What C files did you compile ? All the ones contained in al subdirectories ? May I add a CMakeFiles.txt to al directory ?

TeslaRus commented 4 years ago

yes, all files May I add a CMakeFiles.txt to al directory ? - ok )

RICCIARDI-Adrien commented 4 years ago

@TeslaRus, are you using MinGW on Cygwin ? It seems that Windows threads have been removed from your OpenAL version, only pthreads are left.

TeslaRus commented 4 years ago

yes, mingw has pthreads library (cut version, but enough for AL)

RICCIARDI-Adrien commented 4 years ago

New OpenAL is now fully integrated. It is statically linked to avoid deploying one more DLL.

vvs- commented 4 years ago

I've just checked the result: OpenTomb repository size has doubled because of the Windows binaries. I think that was not a good idea, because git is really bad at handling binaries. I'd split those away or this blow up could become a problem with time.

vvs- commented 4 years ago

Reverted as per discussion in #600.