opentomb / OpenTomb

An open-source Tomb Raider 1-5 engine remake
http://opentomb.github.io/
GNU Lesser General Public License v3.0
1.38k stars 143 forks source link

No splash sound #77

Open vvs- opened 9 years ago

vvs- commented 9 years ago

There is no splash sound when Lara jumps or falls into water. That's true for all game versions. For some strange reason apparently there is a splash sound in youtube videos of OpenTomb. playsound(33) works flawlessly.

Lwmte commented 9 years ago

Splash sound gets muffled by underwater low-pass effect, when camera goes underwater. Possibly, effect is applied incorrectly in your case. Try to set "use_effects = 0" in config and see if it makes any difference.

vvs- commented 9 years ago

Yes, it does. Thanks!

I presume it's still a bug then?

Lwmte commented 9 years ago

Seems more like OpenAL Soft bug - perhaps, you get wrong lowpass filter behaviour there. I already had problems with it long ago, when OpenAL Soft wrongfully set lowpass filter to ~14 kHz frequency, which resulted in totally muffled sounds. Probably it was fixed in 1.16.0, but we're still using 1.15.1 here.

Do you have some other sound-related bugs, like distant sounds aburptly fading in/out, or missing reverb effects in TR3+? If not, I'll try to modify lowpass a bit, and we'll see what happens.

vvs- commented 9 years ago

I didn't notice any sound problems and reverberation is certainly working fine. I noticed a lag in a splash sound when effects are off.

Joey79100 commented 9 years ago

By the way, the sounds never plays when Lara lands in shallow water, even with use_effects = 0.

Lwmte commented 9 years ago

I guess it was hardcoded, as well as animation switch...

P.S.: I can make splash sound global (i. e. without linking to Lara and without environmental FX applied), then it should work in any case. It just may become unrealistic. What I'm waiting for is proper vertical camera smoothing in mlook(0) mode, then problem should be solved automatically, as splash sound will be sent to OpenAL before switching FX.

vvs- commented 9 years ago

That would be awesome. Look for example at the Neptune room in St. Francis' Folly. It's very hard to dive there because of a missing vertical camera alignment. In general it makes camera stuck in a narrow places.

vvs- commented 9 years ago

In TR3+ the splash sound is not always there, e.g. trying to fall back sometimes produce splash but sometimes not.

vvs- commented 9 years ago

In TR3+ produces SYSWARN_AS_NOSAMPLE for some animations.

Lwmte commented 9 years ago

There could be really missing sounds for some animations (like infamous underwater door sound bug), but we should check each animation independently. Can you tell exact animation numbers which produce this warning?

vvs- commented 9 years ago

Actually, any animations while swimming under water.

Joey79100 commented 9 years ago

Probably because of the bubbles sound which is absent in TR3. I've noticed that every sound underwater is barely audible now, they were much stronger before. Maybe that's why they can be almost muted?

vvs- commented 9 years ago

TR4 has the same problem.

Joey79100 commented 9 years ago

I meant TR3+, sorry for the mistyping.

vvs- commented 9 years ago

Probably because of the bubbles sound which is absent in TR3.

That's right. The missing sample is 37. Played in flip effect 3. Related to #287.