opentoonz / opentoonz

OpenToonz - An open-source full-featured 2D animation creation software
https://opentoonz.github.io/
Other
4.53k stars 525 forks source link

Onion skin: Additive tinting doesn't apply to brighter lines #1769

Open MisterABK opened 6 years ago

MisterABK commented 6 years ago

Possibly because the colour overlay is additive? White lines remain white, which makes animating with them much more difficult.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/54278839-onion-skin-tinting-doesn-t-apply-to-white-lines?utm_campaign=plugin&utm_content=tracker%2F33713530&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F33713530&utm_medium=issues&utm_source=github).
RodneyBaker commented 6 years ago

White is working for me in Toonz Raster. I'll do some more testing.

MisterABK commented 6 years ago

Oh! I'm also using toons raster... Perhaps there's a setting I don't know about which could cause this? I made sure that the tinting colour in preferences are still set to the default red and green.

RodneyBaker commented 6 years ago

I will guess you are talking about onion skin in the Level Strips. I was seeing the white in the Xsheet onion skin.

At first glance this appears to be related to having background that isn't white and unfortuately Level strips don't technically have a background other than the default white. I'm not sure if that can be adjusted in a settings file.

For the xsheet and general viewing on the canvas we can change the background either by adjusting the settings of Xsheet > Scene Settings or placing another level underneath the one we are working on.

I need to back up and start again to fully confirm what I'm seeing but as of this moment the only place I'm not seeing onion skin is in the Level Strip. If that is where you are having the problem perhaps we can tweak the settings for that.

I note that if I change the background color (in Scene Settings) to white I can no longer see white lines in onion skin but that is because white on white is white and therefore can't be seen. Changing the background to another color resolves this. I personally like to work (most of the time) with a mid gray background.

MisterABK commented 6 years ago

Just to clarify: I'm working in the Basics view, and I am seeing the onion skin lines, but they appear as semi-transparent white, without the red/green tint. I couldn't work out how to change the canvas colour, so I was using a dark level underneath. I've now set it to grey using the Scene Settings, but it hasn't made the onion skin tint visible.

As a workaround I can change the white lines to a pale grey, at which point they become (very faintly) red and green.

RodneyBaker commented 6 years ago

Ah.... I see what you are saying. Hmmm...

This could have something to do with the Japanese approach to animation with whites and alphas where a pure white reads as transparent.

I apologize for the bad info. Perhaps onionskin only uses 255 levels of gray (black to white scale of transparency) and then just applies the colors set in Preferences on top of that. By that when it processes a purely white line it has nothing to process so it displays the white. White = fully opaque so it displays the original white.

snapai commented 5 years ago

I am also having this issue. Bright yellow or white lines do not get tinted in onion skin (with the default red/green tints), because it's doing an additive tint rather than an alpha-over conversion of the color towards the new color. For example, I get the "right" appearance if I set my linework here to black (though the current frame's linework is hard to see on the dark scene background) - image However bright yellow or bright white do not work: image image

Choosing a pure blue line shows that it's clearly adding the onion skin color to the lines then fading the result, rather than alpha-replacing their colors - instead of green and red we get cyan and magenta. image

Dramaniken commented 4 years ago

Hi, is there an update on a solution or a fix? I can't believe I won't be able to animate with white lines on black with the help of onion skin