search

opentoonz / opentoonz_docs

OpenToonz User Manual
http://opentoonz.readthedocs.io
28 stars 26 forks source link

Many uses of RGBM instead of RGBA #192

Open gab3d opened 5 years ago

gab3d commented 5 years ago

In the TIF file format Options dialog, in the Bits per pixel option it reads RGBM instead of RGBA:

RodneyBaker commented 5 years ago

Informational:

Here's a link to all the instances of the term RGBM both cosmetic and programmatic in the code:

https://github.com/opentoonz/opentoonz/search?q=RGBM&unscoped_q=RGBM

See earlier PRs for when/why RGBM (Red, Green, Blue, Matte) was changed to RGBA (Red, Green, Blue, Alpha).

RodneyBaker commented 4 years ago

As we are heading into v1.4 release it will be good to let all translators know to look for instances of "RGBM" in the .ts files and adjust those to "RGBA". That alone may resolve many appearances of the older abbreviation in the UI.

I'm not convinced that we want to change RGBM to RGBA in all instances of the code source quite yet although I'm sure a full scrub/replacement of every instance would be fine.

RodneyBaker commented 4 months ago

Not quite sure what to do with this one. The delimma would be that of backward and forward compatiblity as well as compatibility with other applications that might use some of the RGBM terminology.

Please reference the previous link that identified 111 occurrences of 'RGBM' in the current code. Most of these are toonz specific references due to favoring of the term matte over alpha in early days of graphical coding. The term matte is still preferred in some cases and with the current use of the Alpha channel expanding into arbitrary channels beyond just transparency I could see RGBM as actually being the more appropriate term to differentiate the contents of the data from that of standard RGB and RGBA.

What we could do is create a PR that changes all instances of RGBM to RGBA and all rgbm to rgba and set it as a "Do Not Merge". Others would then be free to use that in their own builds but it would not be implemented in Opentoonz unless/until we reach some major milestone where sufficient breaking changes occur to warrant the PRs inclusion. We could even tag the PR as 'v2.0' as a suggestion the change and other major changes to code of similar nature can move forward.

It isn't wise in my estimation to keep reports open forever if there is no plan for them. As such, feedback is always welcome on how to chart the best way forward.

Short of this I can only assume a change of all instances of RGBM to RGBA will not be implemented.

RodneyBaker commented 3 months ago

Moving this to Opentoonz-docs as there is no pressing interest in changing the actual code rendering of RGBM to RGBA. It is good to know what RGBM means and how it relates to RGBA however.