search

opentracing-contrib / csharp-netcore

OpenTracing instrumentation for .NET Core 3.1 & .NET 6+ apps
Apache License 2.0
262 stars 74 forks source link

Add logic to capture Http Action #85

Closed bobcat1506 closed 3 years ago

bobcat1506 commented 3 years ago

Adding logic to capture the Http Action from the request to the span's tags.

cwe1ss commented 3 years ago

Hi, thank you very much for the PR, however I feel like this code is too specific as it reads an arbitrary "Action" header. I think it's better if you handle this in your configuration code via the solution described in #83.

bobcat1506 commented 3 years ago

Understood. The header is actually "SOAPAction" and it is defined in the SOAP spec.

I did implement your solution as described in #83.

cwe1ss commented 3 years ago

OK - As you were able to solve this, I'll close this for now and leave #83 open for further feedback. Thanks again!