opentracing-contrib / java-agent

Agent-based OpenTracing instrumentation in Java
Apache License 2.0
41 stars 12 forks source link

Change the scope of not OT related maven dependencies to provided #35

Closed gpolaert closed 6 years ago

gpolaert commented 7 years ago

Hello,

Some of the Java contribs include the client or the driver dependency in the project (such as the AWS Client contrib or the Mongo contrib).

Many developers like lean dependencies for the projects and libraries they used, especially to avoid deps conflicts.

Even if, each README offers a way to exclude some part, I think it would be preferable to set these deps to a scope "provided" and unbind the contrib and the "framework".

The developer will be responsible for adding his own version/client dependencies.

Example:

aws contrib pom.xml

        <dependency>
            <groupId>com.amazonaws</groupId>
            <artifactId>aws-java-sdk</artifactId>
            <scope>provided</scope>
        </dependency>

instead of

       <dependency>
            <groupId>com.amazonaws</groupId>
            <artifactId>aws-java-sdk</artifactId>
            <version>1.11.115</version>
        </dependency>
objectiser commented 7 years ago

I am away this week but feel free to submit a pr and I will review next week. Thanks.

gpolaert commented 7 years ago

Sure, but just let me know if it makes sense :D

objectiser commented 7 years ago

Yes it does make sense.

objectiser commented 6 years ago

Closing. Please re-open if there are further questions.