Annotate 5xx client calls with an error tag

opentracing-contrib / java-jaxrs

OpenTracing Java JAX-RS instrumentation

Apache License 2.0

37 stars 33 forks source link

Annotate 5xx client calls with an error tag #111

Open pavolloffay opened 6 years ago

pavolloffay commented 6 years ago

We could add error tag to client spans for returned 5xx codes.

Related issue for async server API #91

pavolloffay commented 6 years ago

The MP-OT spec defines that error tag SHOULD be added only for 4xx (client codes). If the server side is not traced and 5xx is returned I would also consider that operation as failed or errored.

pavolloffay commented 6 years ago

Reported in MP-OT https://github.com/eclipse/microprofile-opentracing/issues/114