opentracing-contrib / java-jaxrs

OpenTracing Java JAX-RS instrumentation
Apache License 2.0
37 stars 33 forks source link

Add Path annotation based operation name provider (#114) #116

Closed auke- closed 5 years ago

auke- commented 5 years ago

An alternative for the WildcardOperationName implementation (fixes #114).

pavolloffay commented 5 years ago

thanks for the pr @auke-, could you please fix ci to pass?

auke- commented 5 years ago

thanks for the pr @auke-, could you please fix ci to pass?

I tried to understand why the ci is failing, but from what i can see it seems unrelated to my change.

pavolloffay commented 5 years ago

@auke- I have submitted #119 to address my concerns. The idea is to keep only one operation name provider for wildcard path.

auke- commented 5 years ago

Sounds good to me, thanks!