search

opentracing-contrib / java-jdbc

OpenTracing Instrumentation for JDBC
Apache License 2.0
82 stars 56 forks source link

Mark the JAX-RS dependency as `provided` #1

Closed jpkrohling closed 7 years ago

jpkrohling commented 7 years ago

The JAX-RS dependency should be marked as provided, as the party consuming the OT instrumentation has a concrete implementation as dependency already.

This is what's shown as mvn dependency:tree for a Wildfly Swarm application when requiring io.opentracing.contrib:opentracing-jaxrs2:0.0.8:

[INFO] +- io.opentracing.contrib:opentracing-jaxrs2:jar:0.0.8:compile
[INFO] |  +- io.opentracing.contrib:opentracing-concurrent:jar:0.0.1:compile
[INFO] |  \- javax.ws.rs:javax.ws.rs-api:jar:2.0.1:compile
malafeev commented 7 years ago

@jpkrohling I think you submitted issue against wrong project. java-jdbc doesn't have any dependency on jax-rs

Looks like you meant https://github.com/opentracing-contrib/java-jaxrs

jpkrohling commented 7 years ago

Right, sorry :) The issue I have on this repo is another one (#2) .