coveralls
commented
5 years ago Pull Request Test Coverage Report for Build 85
- 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
- 2 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.4%) to 23.579%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/main/java/io/opentracing/contrib/jdbc/TracingDriver.java | 1 | 3 | 33.33% | ||
| <!-- | Total: | 1 | 3 | 33.33% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/main/java/io/opentracing/contrib/jdbc/TracingConnection.java | 2 | 26.74% | ||
| <!-- | Total: | 2 | --> |
| Totals | |
|---|---|
| Change from base Build 84: | -0.4% |
| Covered Lines: | 141 |
| Relevant Lines: | 598 |
malafeev
Current version doesn't allow you to pass Tracer instance to the TracingConnection.
It only works with GlobalTracer.get, which doesn't work when you have multiple tracers in the same jvm.
These changes allow you to (1) set and pass a tracer and (2) to extend this class if you need different behavior.