opentracing-contrib / java-jdbc

OpenTracing Instrumentation for JDBC
Apache License 2.0
82 stars 56 forks source link

Add MariaDB URL Parser to List of ConnectionInfo Parsers #45

Closed jayeve closed 5 years ago

jayeve commented 5 years ago

Problem When using MariaDB url with this library, the ConnectionInfo always shows up as UNKNOWN_CONNECTION_INFO.

Solution This adds a MariadbURLParser class to the map of registered url parsers. The implementation of this parser is effectively piggybacking off the implementation of the MysqlURLParser because the maria URLs are built to be compatible with mysql URLs. the connecting string structure:

jdbc:(mysql|mariadb):[replication:|failover:|sequential:|aurora:]//<hostDescription>[,<hostDescription>...]/[database][?<key1>=<value1>[&<key2>=<value2>]] 
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 154


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/opentracing/contrib/jdbc/parser/MariadbURLParser.java 1 2 50.0%
<!-- Total: 6 7 85.71% -->
Totals Coverage Status
Change from base Build 153: 0.1%
Covered Lines: 383
Relevant Lines: 857

💛 - Coveralls
jayeve commented 5 years ago

Thanks @malafeev. What's the process for releasing these changes?

malafeev commented 5 years ago

@jayeve changes are in 0.1.6 version