opentracing-contrib / java-jdbc

OpenTracing Instrumentation for JDBC
Apache License 2.0
82 stars 56 forks source link

peer.address in tag is not in common tags of opentracing #47

Closed changjiang2016 closed 4 years ago

changjiang2016 commented 5 years ago

peer.address is not common tags of opentracing.Why not use tags,such as peer.hostname and peer.port, instead of peer.address in the code ?

malafeev commented 5 years ago

because it's a trick to extract hostname/port when:

would you like to submit a PR to fix all cases for major databases jdbc url variations?

whiskeysierra commented 5 years ago

peer.address is not common tags of opentracing

It now is: https://github.com/opentracing/specification/pull/53