opentracing-contrib / java-jdbc

OpenTracing Instrumentation for JDBC
Apache License 2.0
82 stars 56 forks source link

Upgrade "io.opentracing.contrib:common" to v0.1.4 #65

Closed safris closed 4 years ago

safris commented 4 years ago

Has a potential fix for this in #60.

cyrille-leclerc commented 4 years ago

Many thanks @safris !

Fix successfully tested with

My problem with opentracing-jdbc:0.2.7 was

Caused by: java.lang.reflect.UndeclaredThrowableException: null
    at com.sun.proxy.$Proxy102.executeQuery(Unknown Source) ~[na:na]
    at com.zaxxer.hikari.pool.ProxyStatement.executeQuery(ProxyStatement.java:111) ~[HikariCP-3.4.1.jar:na]
    at com.zaxxer.hikari.pool.HikariProxyStatement.executeQuery(HikariProxyStatement.java) ~[HikariCP-3.4.1.jar:na]
    at com.wordsmith.words.DatabaseInitializer.postContruct(DatabaseInitializer.java:32) ~[classes/:na]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_232]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_232]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_232]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_232]
    at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleElement.invoke(InitDestroyAnnotationBeanPostProcessor.java:389) ~[spring-beans-5.2.2.RELEASE.jar:5.2.2.RELEASE]
    at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleMetadata.invokeInitMethods(InitDestroyAnnotationBeanPostProcessor.java:333) ~[spring-beans-5.2.2.RELEASE.jar:5.2.2.RELEASE]
    at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:157) ~[spring-beans-5.2.2.RELEASE.jar:5.2.2.RELEASE]
    ... 23 common frames omitted
Caused by: java.lang.reflect.InvocationTargetException: null
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_232]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_232]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_232]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_232]
    at io.opentracing.contrib.jdbc.DynamicProxy$1.invoke(DynamicProxy.java:61) ~[opentracing-jdbc-0.2.7.jar:na]
    ... 34 common frames omitted
Caused by: org.h2.jdbc.JdbcSQLSyntaxErrorException: Table "NOUNS" not found; SQL statement:
select count(*) from nouns [42102-200]
    at org.h2.message.DbException.getJdbcSQLException(DbException.java:453) ~[h2-1.4.200.jar:1.4.200]
    ...
    at org.h2.jdbc.JdbcStatement.executeQuery(JdbcStatement.java:78) ~[h2-1.4.200.jar:1.4.200]
    at io.opentracing.contrib.jdbc.TracingStatement.executeQuery(TracingStatement.java:60) ~[opentracing-jdbc-0.2.7.jar:na]
    ... 39 common frames omitted
safris commented 4 years ago

Hi @cyrille-leclerc, that's great! Thank you for confirming so quickly. This PR will be merged soon, and a release build (non-SNAPSHOT) will follow probably early next week. You can use the SNAPSHOT build until then.

cyrille-leclerc commented 4 years ago

Many thanks. Successfully tested on master branch

git show

commit 70c4c16195e93118693033992682b88e0cfb5b6c (HEAD -> master, origin/master, origin/HEAD)
Author: Seva Safris <seva@safris.org>
Date:   Fri Jan 24 18:37:27 2020 +0700

    Upgrade "io.opentracing.contrib:common" to v0.1.4 (#65)

diff --git a/pom.xml b/pom.xml
index 86fe53d..793f63c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -83,7 +83,7 @@
     <dependency>
       <groupId>io.opentracing.contrib</groupId>
       <artifactId>common</artifactId>
-      <version>0.1.3</version>
+      <version>0.1.4</version>
     </dependency>

     <dependency>