search

opentracing-contrib / java-jdbc

OpenTracing Instrumentation for JDBC
Apache License 2.0
82 stars 56 forks source link

Using Oracle oci driver causes NPE, because of OracleURLParser "thin" expectations #71

Closed ivan-slavchev closed 4 years ago

ivan-slavchev commented 4 years ago

When using "oci" driver instead of "thin" the OracleURLParser is not capable of recognizing the pattern and returns null. This causes NPE later. At the same time the prefix that is expected for the OracleURLParser to pick up the connection string is "jdbc:oracle" and not "jdbc:oracle:thin". This makes it impossible to register custom parser specifically for oci.

malafeev commented 4 years ago

@ivan-slavchev would you like to submit PR?

ivan-slavchev commented 4 years ago

https://github.com/opentracing-contrib/java-jdbc/pull/72

malafeev commented 4 years ago

0.2.10 release with fix will be available in couple of hours