opentracing-contrib / java-jdbc

OpenTracing Instrumentation for JDBC
Apache License 2.0
82 stars 56 forks source link

Get underlying dataSource via unwrap method #78

Closed quaff closed 4 years ago

quaff commented 4 years ago

Before this commit, there is no way to get underlying ds. Is this or adding extra getter method better? WDYT @malafeev ?

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 277


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/opentracing/contrib/jdbc/TracingDataSource.java 0 1 0.0%
<!-- Total: 0 1 0.0% -->
Totals Coverage Status
Change from base Build 275: -0.05%
Covered Lines: 468
Relevant Lines: 982

💛 - Coveralls
malafeev commented 4 years ago

I think getter is better

quaff commented 4 years ago

I think getter is better

done