opentracing-contrib / java-jdbc

OpenTracing Instrumentation for JDBC
Apache License 2.0
82 stars 56 forks source link

Trace commit|rollback|close methods #90

Closed quaff closed 4 years ago

quaff commented 4 years ago

Sometimes those methods will take more time than you think.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 293


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/opentracing/contrib/jdbc/TracingConnection.java 2 3 66.67%
src/main/java/io/opentracing/contrib/jdbc/JdbcTracingUtils.java 7 10 70.0%
<!-- Total: 9 13 69.23% -->
Files with Coverage Reduction New Missed Lines %
src/main/java/io/opentracing/contrib/jdbc/TracingConnection.java 1 25.77%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 291: 0.2%
Covered Lines: 483
Relevant Lines: 1039

💛 - Coveralls
quaff commented 4 years ago

Keep consistency with existed AcquireConnection https://github.com/opentracing-contrib/java-jdbc/blob/master/src/main/java/io/opentracing/contrib/jdbc/TracingDataSource.java#L65