opentracing-contrib / java-jdbc

OpenTracing Instrumentation for JDBC
Apache License 2.0
82 stars 56 forks source link

Implements equals method #97

Open quaff opened 4 years ago

quaff commented 4 years ago

Fix https://github.com/opentracing-contrib/java-jdbc/issues/83

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 311


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/opentracing/contrib/jdbc/TracingDataSource.java 0 7 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingCallableStatement.java 0 9 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingConnection.java 0 9 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingPreparedStatement.java 0 9 0.0%
src/main/java/io/opentracing/contrib/jdbc/TracingStatement.java 0 9 0.0%
<!-- Total: 0 43 0.0% -->
Totals Coverage Status
Change from base Build 310: -2.06%
Covered Lines: 506
Relevant Lines: 1049

💛 - Coveralls
quaff commented 4 years ago

As this doesn't use the trick mentioned in #83 to get through the WrapperProxy/Proxy objects, can you explain how this fixes the problem? Did you test with debugging output and ever get a 'true' result (where the WrapperProxy is used)? No tested, you should provide a minimal test case.

quaff commented 4 years ago

@randallt WrapperProxy added, but I think It should be done by WrapperProxy self.

quaff commented 4 years ago

@randallt Could you provide a test case?