opentracing-contrib / java-jdbc

OpenTracing Instrumentation for JDBC
Apache License 2.0
82 stars 56 forks source link

Add tag "slow" if span is considered slow #99

Closed quaff closed 3 years ago

quaff commented 4 years ago

I'm using jaeger-ui, It can not query traces by span duration, but we could query traces by "slow=true" tag.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 326


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/opentracing/contrib/jdbc/JdbcTracingUtils.java 17 22 77.27%
<!-- Total: 17 22 77.27% -->
Totals Coverage Status
Change from base Build 324: 0.2%
Covered Lines: 514
Relevant Lines: 1017

💛 - Coveralls
pavolloffay commented 4 years ago

@quaff jaeger can query spans by duration.

quaff commented 4 years ago

@quaff jaeger can query spans by duration.

1600246437018 Duration is whole trace duration not span duration.

yurishkuro commented 4 years ago

duration is for the selected service/operation, it applies anywhere in the trace

quaff commented 4 years ago

duration is for the selected service/operation, it applies anywhere in the trace

There are many operations including Query Update Execute Batch, I want query all slow operations in one query.

quaff commented 3 years ago

duration is for the selected service/operation, it applies anywhere in the trace

There are many operations including Query Update Execute Batch, I want query all slow operations in one query.

@yurishkuro Any thoughts?

quaff commented 3 years ago

@yurishkuro updated, thanks.