search

opentracing-contrib / java-jfr-tracer

This is a delegating tracer to be used with OpenTracing. It records span information into the JFR, allowing very deep tracing.
Apache License 2.0
77 stars 14 forks source link

Update Gradle 5 #11

Closed sfriberg closed 5 years ago

sfriberg commented 5 years ago

Allow using Gradle properties as well as ENV variables

sfriberg commented 5 years ago

@thegreystone Do we really care about 9 or move it to 11 compat?

To make it easier in the IDE I wonder if the code should be in two subprojects?

thegreystone commented 5 years ago

@thegreystone Do we really care about 9 or move it to 11 compat?

It was in JDK 9 that the API changes we need to cater for were implemented. That said, I can't imagine anyone running JDK 9 or 10, so it probably wouldn't make much of a difference. Then again, it doesn't hurt to support them.

That said, I don't mind if testing only happens on one pre-JDK 9 (Oracle JDK) platform and OpenJDK 11.

thegreystone commented 5 years ago

To make it easier in the IDE I wonder if the code should be in two subprojects?

It's so tiny amounts of code though (especially in the opentracing-0.32.0 branch). Personally I don't mind leaving it as it is. At some point the world will all be on 11 (let's pray to his Noodliness that this will happen before retirement) and we can just move a few classes and drop JDK 7 and 8 compatibility. :)