opentracing-contrib / java-kafka-client

OpenTracing Instrumentation for Apache Kafka Client
Apache License 2.0
125 stars 64 forks source link

Adding 'peer.service' tag indicating remote service #35

Closed peterjurkovic closed 6 years ago

peterjurkovic commented 6 years ago

Based on Open Tracing Semantic Conventions there should be also peer.service tag:

Remote service name (for some unspecified definition of "service"). E.g., "elasticsearch", "a_custom_microservice", "memcache". Meaning should correspond with values set in service.

In this case "kafka". Based on this tag tracing implementors can render UI. Any reason why was not added?

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 117


Totals Coverage Status
Change from base Build 116: 0.4%
Covered Lines: 186
Relevant Lines: 322

💛 - Coveralls
malafeev commented 6 years ago

thanks @peterjurkovic