opentracing-contrib / java-kafka-client

OpenTracing Instrumentation for Apache Kafka Client
Apache License 2.0
125 stars 64 forks source link

TracingProducerFactory is not compatible with spring-kafka:2.3.1 #60

Closed ZawadaZSE closed 5 years ago

ZawadaZSE commented 5 years ago

Hey,

SpringKafka added new method to ProducerFactory interface with this change: https://github.com/spring-projects/spring-kafka/pull/1105 which makes opentracing-kafka-spring incompatible with SpringKafka 2.3.0+

Because of that TracingProducerFactory does not work (UnsupportedOperationException("This factory does not support this method") is thrown)

SpringKafka 2.3.1 is default for SpringBoot 2.2.0

malafeev commented 5 years ago

fixed via #61

ZawadaZSE commented 5 years ago

That was fast ;) Thanks!