Override additional methods in TracingProducerFactory to avoid Unsupp…

opentracing-contrib / java-kafka-client

OpenTracing Instrumentation for Apache Kafka Client

Apache License 2.0

125 stars 64 forks source link

Override additional methods in TracingProducerFactory to avoid Unsupp… #87

Closed RuslanHryn closed 3 years ago

RuslanHryn commented 3 years ago

Currently, TracingProducerFactory is not implementing all methods from ProducerFactory. Therefore, if use an unimplemented method then you may get UnsupportedOperationException I've implemented all method to fix this issue

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 259

0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.4%) to 66.026%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
opentracing-kafka-spring/src/main/java/io/opentracing/contrib/kafka/spring/TracingProducerFactory.java	0	10	0.0%
<!--	Total:	0	10	0.0%	-->

Totals
Change from base Build 257:	-1.4%
Covered Lines:	309
Relevant Lines:	468

💛 - Coveralls

hpuac commented 3 years ago

Hey @RuslanHryn and @malafeev, thx for fixing this! It's exactly the issue we currently run into when updating the tracing dependencies. When can we expect to get a new tag? :slightly_smiling_face:

JonathanHel commented 3 years ago

Any updates for a new release? We definitly need this! @RuslanHryn @malafeev

aadamovi commented 2 years ago

hi, I have a similar issue. was this fix released? if so what is the version? thx

unv-unv commented 1 year ago

Still no release with this fix available in https://mvnrepository.com/artifact/io.opentracing.contrib/opentracing-kafka-spring