search

opentracing-contrib / java-metrics

Apache License 2.0
31 stars 9 forks source link

Add observer impl - instead of using own SpanData interface, it now u… #11

Closed objectiser closed 7 years ago

objectiser commented 7 years ago

…ses the Observer's version, so this will affect any metric reporters

Created this PR as an example for how the Observer API could be used. Requires more tests.

objectiser commented 7 years ago

@jpkrohling Could you review this please? Its an update to remove the internal tracer wrapper and instead switch over to using the observer (and its tracer wrapper). There were also some formatting changes.

Also added a slight update, to enable multiple MetricsReporters to be specified - to support different sets of labels.

objectiser commented 7 years ago

Tested against example: https://github.com/objectiser/opentracing-prometheus-example

objectiser commented 7 years ago

@jpkrohling Thanks!