search

opentracing-contrib / java-metrics

Apache License 2.0
31 stars 9 forks source link

Switch to Micrometer #26

Closed jpkrohling closed 5 years ago

jpkrohling commented 6 years ago

@objectiser wrote:

Currently the https://github.com/opentracing-contrib/java-metrics project provides a prometheus only reporter.

A micrometer based reporter should be implemented, and the current prometheus reporter deprecated.

NOTE: the current metric names are specific to the way that prometheus reports histogram data - using three parts representing the 'count', 'sum' and 'buckets'. For micrometer, it may be better to report the data differently in a way that would be consistent across different metric backends - and as a consequence it may be better to use the micrometer API directly rather than having the reporter interface.

jpkrohling commented 6 years ago

@objectiser should the Spring Auto Configuration for Prometheus use the new Micrometer backend? Or should it also be marked as deprecated, and require the target applications to provide the necessary beans?

objectiser commented 6 years ago

@jpkrohling Depends how you want to implement it - the MetricsObserver could directly interface to micrometer cutting out the MetricsReporter abstraction - although that might mean having to worry about deprecating more. And then the metrics observer spring auto config + a suitable micrometer backend in the classpath may be enough.

But if keeping the MetricsReporter and providing an alternative micrometer based impl, then I guess have a separate opentracing-metrics-micrometer-spring-autoconfigure artifact?

jpkrohling commented 5 years ago

@objectiser do you think this can be closed?

objectiser commented 5 years ago

Closed by #27