opentracing-contrib / java-specialagent

Automatic instrumentation for 3rd-party libraries in Java applications with OpenTracing.
Apache License 2.0
185 stars 46 forks source link

lightstep logging is not working #340

Open zeitlinger opened 4 years ago

zeitlinger commented 4 years ago

the lightstep bundle does not have an slf4j implementation, hence logging is completely turned off, regardless of ls.verbosity

I'm not sure where the slf4j implementation is supposed to be provided - hence I didn't create a PR

  1. in the bundle
  2. in this repo
  3. somehow in the target application
        <dependency>
          <groupId>com.lightstep.tracer</groupId>
          <artifactId>lightstep-tracer-jre-bundle</artifactId>
          <version>0.17.0</version>
          <scope>provided</scope>
        </dependency>
safris commented 4 years ago

Hi @zeitlinger, the lightstep-tracer-jre-bundle is not the LightStep Tracer. It is a middleman between the SpecialAgent and the LightStep Tracer. The plugin docs specify which parameters are available, and ls.verbosity is not one of them.

Nevertheless, I do believe that ls.verbosity should be a supported parameter. Please file an issue with LightStep Tracer.

zeitlinger commented 4 years ago

OK, created an issue.