search

opentracing-contrib / java-spring-cloud

Distributed tracing for Spring Boot, Cloud and other Spring projects
Apache License 2.0
390 stars 143 forks source link

starter project for Haystack #189

Open mchandramouli opened 5 years ago

mchandramouli commented 5 years ago

How - how do we go about adding a spring cloud starter project for Haystack? We will be happy to contribute and maintain that project. Alternately, we can host it in Expediadotcom org and issue an update to your documentation. Let me know

pavolloffay commented 5 years ago

This is just instrumentation. You can use it with any OpenTracing compatible tracer and create integrations like these:

https://github.com/opentracing-contrib/java-spring-zipkin https://github.com/opentracing-contrib/java-spring-jaeger

Or is there something else required to make it work with Haystack?

mchandramouli commented 5 years ago

@pavolloffay Haystack is an opentracing compatible tracer. I am adding a springboot integration similar to what you have for zipkin and jaeger in opentracing-contrib. Should I just issue pull for your documentation adding Haystack's integration as well or do you prefer I move my integration library to opentracing-contrib? similar to zipkin and jaeger, all the library does is create a Tracer instance so it can work with opentracing-spring-web-starter

pavolloffay commented 5 years ago

@mchandramouli as you prefer we can move the repo to opentracing-contrib or just add docs with the repo location to this repository.

mchandramouli commented 5 years ago

Great. Here is our README link https://github.com/ExpediaDotCom/haystack-client-java/tree/master/integrations/opentracing-spring-haystack-web-starter - Will issue a pull to your documentation

pavolloffay commented 5 years ago

Thanks for the pointer, you are welcome to create a PR and add it to https://github.com/opentracing-contrib/java-spring-cloud#configuration.