search

opentracing-contrib / java-spring-cloud

Distributed tracing for Spring Boot, Cloud and other Spring projects
Apache License 2.0
388 stars 143 forks source link

Add support to set prefix Redis operation name #292

Closed luramarchanjo closed 4 years ago

luramarchanjo commented 4 years ago

Resolves #291

luramarchanjo commented 4 years ago

@mp911de can you review this?

pavolloffay commented 4 years ago

@malafeev could you please review and provide feedback on the issue?

Scoping the name for component/redis instrumentation makes sense. Although the same could be done by using operation name selector and tag component=redis (the redis instrumentation should set this tag).

malafeev commented 4 years ago

lgtm, prefix can be more specific, but component name is just java-redis.